THV-0057: Address review feedback on rate limiting RFC#66
Merged
Conversation
Updates include: middleware ordering (auth → mcp-parser → rate limit), config field renames (maxTokens, refillPeriod as Duration), admission-time validation, namespace in Redis keys, vMCP field placement at spec level, optimizer interaction as tech debt, JSON-RPC error format, observability metrics, fail-open semantics, and additional alternatives considered. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisJBurns
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all 18 review comments from @ChrisJBurns on THV-0057 (Rate Limiting for MCP Servers).
Key changes:
Auth → MCP Parser → RateLimit → [remaining chain]capacity→maxTokens,refillPeriodSeconds→refillPeriod(Duration type)RateLimitingConfigValidstatus conditionspec.config.rateLimitingtospec.rateLimitingfor consistent CRD validation-32029andRetry-Afterinerror.dataTest plan
🤖 Generated with Claude Code